Make losing client ID optional in bulk transfers - #3169
Merged
Conversation
CydeWeys
commented
Jul 21, 2026
CydeWeys
force-pushed
the
optional-losing-client
branch
from
July 21, 2026 16:31
d30aa28 to
d3c8449
Compare
CydeWeys
force-pushed
the
optional-losing-client
branch
from
July 21, 2026 17:49
d3c8449 to
146d562
Compare
CydeWeys
commented
Jul 28, 2026
CydeWeys
left a comment
CydeWeys
left a comment
Member
Author
There was a problem hiding this comment.
@CydeWeys resolved 1 discussion.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on jicelhay).
jicelhay
approved these changes
Jul 28, 2026
jicelhay
left a comment
jicelhay
left a comment
Collaborator
There was a problem hiding this comment.
@jicelhay reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
When executing bulk domain transfers with an explicit list of domain names or a domain names file, enforcing by losing registrar ID is often unnecessary and redundant (b/537294004). This commit makes --losing_registrar_id an optional command-line parameter and updates BulkDomainTransferAction and BatchModule to handle an optional losing sponsor ID. Existing behavior is preserved when the parameter is explicitly supplied. BUG= http://b/537294004
CydeWeys
force-pushed
the
optional-losing-client
branch
from
July 28, 2026 16:07
146d562 to
a22f528
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing bulk domain transfers with an explicit list of domain names or a domain names file, enforcing by losing registrar ID is often unnecessary and redundant (b/537294004).
This commit makes --losing_registrar_id an optional command-line parameter and updates BulkDomainTransferAction and BatchModule to handle an optional losing sponsor ID. Existing behavior is preserved when the parameter is explicitly supplied.
BUG= http://b/537294004
This change is